Skip to content

chore: minor cleanups#1286

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
OrbisK:chore/minor-cleanups
Feb 9, 2026
Merged

chore: minor cleanups#1286
danielroe merged 2 commits intonpmx-dev:mainfrom
OrbisK:chore/minor-cleanups

Conversation

@OrbisK
Copy link
Contributor

@OrbisK OrbisK commented Feb 9, 2026

I was looking through last weeks changes. I made some minor cleanups as I went along.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

This pull request refactors multiple composables and a page component to optimise reactivity tracking. Several composables switch from standard ref() to shallowRef() for primitive boolean and simple values (isRateLimited, activeId, canGoBack, isLikeActionPending). The useCharts composable centralises date parsing through a dedicated parseIsoDateOnly helper. useFileTreeState removes a computed wrapper for state key generation, using direct string concatenation instead. usePreferencesProvider adds the defu utility for safer object merging, constrains its generic type parameter to object, and replaces the spread operator merge strategy with defu() for loading stored preferences.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is vague and generic, using non-descriptive terms like 'minor cleanups' without explaining what was actually changed or why. Provide specific details about what cleanups were made, such as refactoring ref to shallowRef, updating merge strategies, or removing intermediate computed wrappers.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 9, 2026 5:16pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 9, 2026 5:16pm
npmx-lunaria Ignored Ignored Feb 9, 2026 5:16pm

Request Review

@danielroe danielroe enabled auto-merge February 9, 2026 16:57
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/composables/useActiveTocItem.ts 0.00% 1 Missing ⚠️
app/composables/useCanGoBack.ts 0.00% 1 Missing ⚠️
app/pages/package/[[org]]/[name].vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 9, 2026
Merged via the queue into npmx-dev:main with commit 0f5adf3 Feb 9, 2026
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants